Build and Learn

Code Reviews: Giving and Receiving Feedback


Listen Later

Disclaimer: The episode on Creating Pull Requests got lost so Episode 6 ended up being our Build vs Buy episode. 


Upcoming Conferences Of Note

  • Rails SaaS - Oct 6-7, 2022 (already happened)
  • Ruby Conf Mini - Nov 15-17
  • RubyConf - Nov 29-Dec 1
  • Chirp - Nov 16th

Pull Request Guide from Thoughtbot

Other Tips for giving a nice PR review

Remember the person on the other end of your review is a human. As devs it’s easy to mix our identity with the code we write and any criticism of that code can be challenging to absorb.

  • Timeliness 
    • Respond quickly if you are a reviewer
    • This can be especially challenging when dealing with major differences in timezone
  • Checklists 
    • Does this code belong somewhere else?
    • Is this code tested?
    • Do I understand this code? 
      • PRs can be a way to do knowledge transfer to other folks on the team
    • Are there any glaring security concerns?
    • Should someone else also review this change?
    • What might go wrong when this is deployed? 
      • Is there observability in place?
      • Is there a large migration that needs special treatment?
  • Other things: 
    • I try to group all of my replies into one big response rather than lots of individual comments, that way the

Tools Mentioned

  • Graphite.dev


...more
View all episodesView all episodes
Download on the App Store

Build and LearnBy CJ Avilla, Colin Loretz

  • 5
  • 5
  • 5
  • 5
  • 5

5

2 ratings