For several decades, car spy photography was lucrative and exciting work. But only for those prepared to go the extra mile, writes Richard Porter